RFR: 8298939: Refactor open/test/jdk/javax/rmi/ssl/SSLSocketParametersTest.sh to jtreg java test

Matthew Donovan duke at openjdk.org
Tue Feb 7 16:05:18 UTC 2023


On Tue, 7 Feb 2023 15:54:06 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

>> Removed SSLSocketParametersTest.sh script (which just called a Java file) and configured the java code to run directly with jtreg
>
> test/jdk/javax/rmi/ssl/SSLSocketParametersTest.java line 192:
> 
>> 190:                         throw exc;
>> 191:                     }
>> 192:                 }
> 
> What is the story with the different exception catching here and in case 5? It doesn't look like a simple refactoring. Is another bug being fixed here?

The expected result of cases 4 and 5 is that an IllegalArgumentException is thrown because of the unsupported ciphersuite. The original code just caught `Exception` which would hide a problem in the test e.g., if `SSLContext.getDefault()` throws the NoSuchAlgorithmException.

-------------

PR: https://git.openjdk.org/jdk/pull/11910


More information about the core-libs-dev mailing list