RFR: 8298939: Refactor open/test/jdk/javax/rmi/ssl/SSLSocketParametersTest.sh to jtreg java test

Daniel Fuchs dfuchs at openjdk.org
Tue Feb 7 16:17:05 UTC 2023


On Tue, 7 Feb 2023 16:02:30 GMT, Matthew Donovan <duke at openjdk.org> wrote:

>> test/jdk/javax/rmi/ssl/SSLSocketParametersTest.java line 192:
>> 
>>> 190:                         throw exc;
>>> 191:                     }
>>> 192:                 }
>> 
>> What is the story with the different exception catching here and in case 5? It doesn't look like a simple refactoring. Is another bug being fixed here?
>
> The expected result of cases 4 and 5 is that an IllegalArgumentException is thrown because of the unsupported ciphersuite. The original code just caught `Exception` which would hide a problem in the test e.g., if `SSLContext.getDefault()` throws the NoSuchAlgorithmException.

OK - but the run( ) method catches IllegalArgumentException already?

-------------

PR: https://git.openjdk.org/jdk/pull/11910


More information about the core-libs-dev mailing list