RFR: 8298939: Refactor open/test/jdk/javax/rmi/ssl/SSLSocketParametersTest.sh to jtreg java test [v2]

Matthew Donovan duke at openjdk.org
Tue Feb 7 19:33:24 UTC 2023


On Tue, 7 Feb 2023 16:13:40 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

>> The expected result of cases 4 and 5 is that an IllegalArgumentException is thrown because of the unsupported ciphersuite. The original code just caught `Exception` which would hide a problem in the test e.g., if `SSLContext.getDefault()` throws the NoSuchAlgorithmException.
>
> OK - but the run( ) method catches IllegalArgumentException already?

The exception is actually being thrown from the `ServerFactory` constructor.  I updated the code to remove the call to `run()` and added a comment clarifying the exception handling.

-------------

PR: https://git.openjdk.org/jdk/pull/11910


More information about the core-libs-dev mailing list