RFR: 8293667: Align jlink's --compress option with jmod's --compress option [v6]

[Ian Graves]

On Tue, 14 Feb 2023 20:20:03 GMT, Mandy Chung <mchung at openjdk.org> wrote:

>> Ian Graves has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fixing up resources
>
> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/CompactConstantPoolsPlugin.java line 48:
> 
>> 46: 
>> 47:     public CompactConstantPoolsPlugin() {
>> 48:         super("compact-constant-pools");
> 
> This plugin needs a better option name.   Maybe `--share-utf8-entries`?
> 
> I also wonder if anyone really uses this plugin.  It writes the shared UTF8 strings into the jimage.  It incurs overhead in reconstructing the constant pool when loading classes.    So I wonder if we just drop this plugin - @AlanBateman, @igraves what do you think?

I think that deprecating the entire plugin could be appropriate, given the overhead, unless there's some performance data to the contrary. I haven't seen much in favor of keeping it, but I do think that breaking it apart from zip before deprecating it is also fine.

-------------

PR: https://git.openjdk.org/jdk/pull/11617