RFR: 8293667: Align jlink's --compress option with jmod's --compress option [v6]

Mandy Chung mchung at openjdk.org
Wed Feb 15 18:25:43 UTC 2023


On Wed, 15 Feb 2023 14:56:27 GMT, Ian Graves <igraves at openjdk.org> wrote:

>> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/CompactConstantPoolsPlugin.java line 48:
>> 
>>> 46: 
>>> 47:     public CompactConstantPoolsPlugin() {
>>> 48:         super("compact-constant-pools");
>> 
>> This plugin needs a better option name.   Maybe `--share-utf8-entries`?
>> 
>> I also wonder if anyone really uses this plugin.  It writes the shared UTF8 strings into the jimage.  It incurs overhead in reconstructing the constant pool when loading classes.    So I wonder if we just drop this plugin - @AlanBateman, @igraves what do you think?
>
> I think that deprecating the entire plugin could be appropriate, given the overhead, unless there's some performance data to the contrary. I haven't seen much in favor of keeping it, but I do think that breaking it apart from zip before deprecating it is also fine.

If we are planning to drop this, we will not need to introduce a new plugin option but instead states that `--compress 1` will be deprecated and removed in a future release.

-------------

PR: https://git.openjdk.org/jdk/pull/11617


More information about the core-libs-dev mailing list