RFR: 8293667: Align jlink's --compress option with jmod's --compress option [v9]

Mandy Chung mchung at openjdk.org
Thu Feb 16 23:15:53 UTC 2023


On Thu, 16 Feb 2023 23:07:13 GMT, Ian Graves <igraves at openjdk.org> wrote:

>> This is an approach to adding a flag to jlink that will allow --compress to take the same types of arguments as jmod, thus bringing the two into alignment. This likely requires a CSR and a discussion on whether we should deprecate or simply remove the original numeric compression arguments.
>
> Ian Graves has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Additional updates

This change also impacts runtime.  Is it possible to add a test that runs jlink to create a custom image that uses some compression level and run the compressed resources in the custom image.

src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/DefaultCompressPlugin.java line 95:

> 93:             switch (level) {
> 94:                 case LEVEL_0:
> 95:                     System.err.println("warning - the \"0\" value for --compress has been deprecated and " +

I expect this be a localized message, e.g. add to plugins.properties.   You can call AbstractPlugin::getMessage` to get the message from the resource bundle.  This one should be consistent with the existing convention but unfortunately the existing warning messages are not consistent - prefixing with "Warning:" or "WARNING:".

-------------

PR: https://git.openjdk.org/jdk/pull/11617


More information about the core-libs-dev mailing list