RFR: 8293667: Align jlink's --compress option with jmod's --compress option [v9]

Ian Graves igraves at openjdk.org
Fri Feb 17 03:13:59 UTC 2023


On Thu, 16 Feb 2023 23:04:30 GMT, Mandy Chung <mchung at openjdk.org> wrote:

>> Ian Graves has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Additional updates
>
> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/DefaultCompressPlugin.java line 95:
> 
>> 93:             switch (level) {
>> 94:                 case LEVEL_0:
>> 95:                     System.err.println("warning - the \"0\" value for --compress has been deprecated and " +
> 
> I expect this be a localized message, e.g. add to plugins.properties.   You can call `AbstractPlugin::getMessage` to get the message from the resource bundle.  This one should be consistent with the existing convention but unfortunately the existing warning messages are not consistent - prefixing with "Warning:" or "WARNING:".

Thanks. I note that there is a non-localized warning done this way elsewhere in jlink. May need to make a bug to localize this.

-------------

PR: https://git.openjdk.org/jdk/pull/11617


More information about the core-libs-dev mailing list