RFR: 8303133: Update ProcessTools.startProcess(...) to exit early if process exit before linePredicate is printed.

Roger Riggs rriggs at openjdk.org
Fri Feb 24 22:48:02 UTC 2023


On Fri, 24 Feb 2023 22:15:18 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:

> The solution proposed by Stefan K
> 
> The startProcess() might wait forever for the expected line if the process exits (failed to start). It makes sense to just fail earlier in such cases.
> 
> The fix also move
> 'output = new OutputAnalyzer(this.process);'
> in method xrun() to be able to try to print them in waitFor is failed/interrupted.

test/lib/jdk/test/lib/thread/ProcessThread.java line 168:

> 166:                 output = new OutputAnalyzer(this.process);
> 167:                 // Will block...
> 168:                 this.process.waitFor();

It would be useful to capture the exit status here for the log.

-------------

PR: https://git.openjdk.org/jdk/pull/12751


More information about the core-libs-dev mailing list