RFR: 8303133: Update ProcessTools.startProcess(...) to exit early if process exit before linePredicate is printed. [v2]

Leonid Mesnik lmesnik at openjdk.org
Sat Feb 25 00:19:33 UTC 2023


On Fri, 24 Feb 2023 22:41:34 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> Leonid Mesnik has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   updated to always check if process is alive.
>
> test/lib/jdk/test/lib/process/ProcessTools.java line 228:
> 
>> 226:                     }
>> 227:                 } else {
>> 228:                     if (!latch.await(Utils.adjustTimeout(timeout), unit)) {
> 
> Checking for liveness in both timeout ==0 and > 0 would be useful.

fixed

> test/lib/jdk/test/lib/thread/ProcessThread.java line 168:
> 
>> 166:                 output = new OutputAnalyzer(this.process);
>> 167:                 // Will block...
>> 168:                 this.process.waitFor();
> 
> It would be useful to capture the exit status here for the log.

It is printed anyway in ProcessTools.getProcessLog(...)

-------------

PR: https://git.openjdk.org/jdk/pull/12751


More information about the core-libs-dev mailing list