RFR: 8311630: [s390] Implementation of Foreign Function & Memory API (Preview) [v3]

[sid8606]

On Tue, 25 Jul 2023 21:26:06 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

>> sid8606 has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Address suggestions from Jorn Vernee
>
> src/hotspot/cpu/s390/downcallLinker_s390.cpp line 162:
> 
>> 160: 
>> 161:   assert(!_needs_return_buffer, "unexpected needs_return_buffer");
>> 162:   bool should_save_return_value = _needs_transition;;
> 
> This should always be `true`, so I don't think you need the `if` statements around the spill/fill code below.
> 
> See: https://github.com/openjdk/jdk/pull/15025 (`should_save_return_value` being dependent on `_needs_transition` is a bug).

Thank you, I'll make changes.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14801#discussion_r1275736710