RFR: 8311630: [s390] Implementation of Foreign Function & Memory API (Preview) [v3]

[sid8606]

On Thu, 27 Jul 2023 05:05:57 GMT, sid8606 <duke at openjdk.org> wrote:

>> src/hotspot/cpu/s390/downcallLinker_s390.cpp line 162:
>> 
>>> 160: 
>>> 161:   assert(!_needs_return_buffer, "unexpected needs_return_buffer");
>>> 162:   bool should_save_return_value = _needs_transition;;
>> 
>> This should always be `true`, so I don't think you need the `if` statements around the spill/fill code below.
>> 
>> See: https://github.com/openjdk/jdk/pull/15025 (`should_save_return_value` being dependent on `_needs_transition` is a bug).
>
> Thank you, I'll make changes.

Made the changes in a new commit

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14801#discussion_r1277065390