RFR: 8311630: [s390] Implementation of Foreign Function & Memory API (Preview) [v6]

Andrew Haley aph at openjdk.org
Fri Jul 28 12:38:56 UTC 2023


On Fri, 28 Jul 2023 03:59:26 GMT, sid8606 <duke at openjdk.org> wrote:

>> Implementation of "Foreign Function & Memory API" for s390x (Big Endian).
>
> sid8606 has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Preserve and restore register Z_R6
>   
>   Though Z_R6 is argument register it is a saved register
>   so preserve and restore Z_R6 register

src/hotspot/cpu/s390/upcallLinker_s390.cpp line 72:

> 70:     // Z_SP saved/restored by prologue/epilogue
> 71:     if (reg == Z_SP) continue;
> 72:     // though Z_R6 is argument register it is a saved register

Suggestion:
`    // although Z_R6 is used for parameter passing, it must be saved and restored by a called function.`

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14801#discussion_r1277496026


More information about the core-libs-dev mailing list