RFR: 8311630: [s390] Implementation of Foreign Function & Memory API (Preview) [v6]

[sid8606]

On Fri, 28 Jul 2023 12:36:13 GMT, Andrew Haley <aph at openjdk.org> wrote:

>> sid8606 has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Preserve and restore register Z_R6
>>   
>>   Though Z_R6 is argument register it is a saved register
>>   so preserve and restore Z_R6 register
>
> src/hotspot/cpu/s390/upcallLinker_s390.cpp line 72:
> 
>> 70:     // Z_SP saved/restored by prologue/epilogue
>> 71:     if (reg == Z_SP) continue;
>> 72:     // though Z_R6 is argument register it is a saved register
> 
> Suggestion:
> `    // although Z_R6 is used for parameter passing, it must be saved and restored by a called function.`

Thanks for the review. Fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14801#discussion_r1278922263