RFR: JDK-8308913: Update core reflection for JEP 445 (preview) [v4]

Mandy Chung mchung at openjdk.org
Fri Jun 2 16:47:09 UTC 2023


On Fri, 2 Jun 2023 04:48:35 GMT, Joe Darcy <darcy at openjdk.org> wrote:

>> Explain in java.lang.Class how unnamed classes are modeled in core reflection.
>
> Joe Darcy has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update reflective support.

src/java.base/share/classes/java/lang/Class.java line 1884:

> 1882:                     reflective=true)
> 1883:     public boolean isUnnamedClass() {
> 1884:         return isSynthetic() && PreviewFeatures.isEnabled() && isTopLevelClass();

Should this include more tests such as not abstract, final, package access, in an unnamed package, etc to accurately determine it's an unnamed class?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14165#discussion_r1214597498


More information about the core-libs-dev mailing list