RFR: JDK-8308913: Update core reflection for JEP 445 (preview) [v4]

[Joe Darcy]

On Fri, 2 Jun 2023 16:44:35 GMT, Mandy Chung <mchung at openjdk.org> wrote:

>> Joe Darcy has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update reflective support.
>
> src/java.base/share/classes/java/lang/Class.java line 1884:
> 
>> 1882:                     reflective=true)
>> 1883:     public boolean isUnnamedClass() {
>> 1884:         return isSynthetic() && PreviewFeatures.isEnabled() && isTopLevelClass();
> 
> Should this include more tests such as not abstract, final, package access, in an unnamed package, etc to accurately determine it's an unnamed class?

Hmm. I think adding at least a check for ACC_FINAL should be fine as it should have near-zero cost on top of the existing predicate once the method get compiled. (In future iterations of the JEP, the idiom to identify isUnnamed will likely change.)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14165#discussion_r1214633943