RFR: 8309216: Cast from jchar* to char* in test java/io/GetXSpace.java [v2]

Brian Burkhalter bpb at openjdk.org
Fri Jun 2 19:23:12 UTC 2023


On Fri, 2 Jun 2023 18:37:27 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:

>> test/jdk/java/io/File/libGetXSpace.c line 85:
>> 
>>> 83:         // use GetDiskSpaceInformationW
>>> 84:         DISK_SPACE_INFORMATION diskSpaceInfo;
>>> 85:         BOOL hres = pfnGetDiskSpaceInformation(path, &diskSpaceInfo);
>> 
>> The strchars/path could be released before checking the return; keeping the cleanup in the common flow.
>> Here and below after calling GetDiskFreeSpaceExW.
>> Your call.
>
> Good idea; will update.

So changed in 0ecf89b1d060bb8c1a35402ec108cbe9f3f35bb9.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14276#discussion_r1214735984


More information about the core-libs-dev mailing list