RFR: 8309216: Cast from jchar* to char* in test java/io/GetXSpace.java [v2]
Naoto Sato
naoto at openjdk.org
Fri Jun 2 22:04:05 UTC 2023
On Fri, 2 Jun 2023 18:36:56 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:
>> test/jdk/java/io/File/libGetXSpace.c line 142:
>>
>>> 140: for (int i = 0; i < len; i++) {
>>> 141: chars[i] = (char)strchars[i];
>>> 142: }
>>
>> Is this `memcpy(chars, strchars, len);`
>
> I don't think so if `chars` is `char *` and `strchars` is `jchar*` as I think `char` is 8 bits and `jchar` is 16 bits.
I just wonder if jchar is UTF-16 and char is platform encoding, would it work by simply casting the low 8bit to char?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14276#discussion_r1214882192
More information about the core-libs-dev
mailing list