RFR: 8309216: Cast from jchar* to char* in test java/io/GetXSpace.java [v2]
Brian Burkhalter
bpb at openjdk.org
Fri Jun 2 22:21:04 UTC 2023
On Fri, 2 Jun 2023 22:00:48 GMT, Naoto Sato <naoto at openjdk.org> wrote:
>> I don't think so if `chars` is `char *` and `strchars` is `jchar*` as I think `char` is 8 bits and `jchar` is 16 bits.
>
> I just wonder if jchar is UTF-16 and char is platform encoding, would it work by simply casting the low 8bit to char?
Probably not. This is only intended to cover the constrained case of this test. Something like the macro `WITH_PLATFORM_STRING` in `libjava/io_util.h` would be needed for the general case, but I thought that that might be overdoing it for here. I could of course be mistaken.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14276#discussion_r1214895770
More information about the core-libs-dev
mailing list