RFR: 8306431: File.listRoots method description should be re-examined [v7]
Brian Burkhalter
bpb at openjdk.org
Mon Jun 5 18:17:37 UTC 2023
On Mon, 22 May 2023 07:27:00 GMT, Nagata-Haruhito <duke at openjdk.org> wrote:
>> I fixed File.listRoots description.
>> * remove "the insertion or ejection of removable media"
>> * change "available" to "existing"
>>
>> Please review this change.
>
> Nagata-Haruhito has updated the pull request incrementally with one additional commit since the last revision:
>
> Move SecurityException paragraph
src/java.base/share/classes/java/io/File.java line 1821:
> 1819: * root directories of the available filesystem roots. It is guaranteed
> 1820: * that the canonical pathname of any file physically present on the local
> 1821: * machine will begin with one of the roots returned by this method.
@Nagata-Haruhito Per @AlanBateman 's suggestion, would you please add this sentence
“There is no guarantee that the root directory can be accessed”
or the equivalent here after “returned by this method” and after the sentence that begins with “A file system ...” in the specification of `java.nio.file.FileSystem::getRootDirectories` and so update this PR?
Thanks.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13526#discussion_r1218417925
More information about the core-libs-dev
mailing list