RFR: 8306431: File.listRoots method description should be re-examined [v7]

Nagata-Haruhito duke at openjdk.org
Wed Jun 7 08:16:35 UTC 2023


On Mon, 5 Jun 2023 18:04:09 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:

>> Nagata-Haruhito has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Move SecurityException paragraph
>
> src/java.base/share/classes/java/io/File.java line 1821:
> 
>> 1819:      * root directories of the available filesystem roots.  It is guaranteed
>> 1820:      * that the canonical pathname of any file physically present on the local
>> 1821:      * machine will begin with one of the roots returned by this method.
> 
> @Nagata-Haruhito Per @AlanBateman 's suggestion, would you please add this sentence
> 
> “There is no guarantee that the root directory can be accessed”
> 
> or the equivalent here after “returned by this method” and after the sentence that begins with “A file system ...” in the specification of `java.nio.file.FileSystem::getRootDirectories` and so update this PR?
> 
> Thanks.

Thanks for your advice. I changed description as your advice. I will publish CSR with this change.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13526#discussion_r1221124434


More information about the core-libs-dev mailing list