RFR: 8307840: SequencedMap view method specification and implementation adjustments
Jaikiran Pai
jpai at openjdk.org
Tue Jun 6 05:01:51 UTC 2023
On Thu, 1 Jun 2023 16:18:12 GMT, Stuart Marks <smarks at openjdk.org> wrote:
> Adjust the specification of the `SequencedMap` sequenced-view methods, and adjust implementations to match.
src/java.base/share/classes/java/util/AbstractMap.java line 908:
> 906: public boolean add(E t) { throw uoe(); }
> 907: public boolean addAll(Collection<? extends E> c) { throw uoe(); }
> 908: public void clear() { view().clear(); }
Each of these methods should perhaps have the `@Override` to make it clear that these correspond to the interface this class is implementing. But I see that the `AbstractMap` class itself doesn't use `@Override` anywhere, so I think it's OK to keep it consistent in its current form in this PR.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14267#discussion_r1218900019
More information about the core-libs-dev
mailing list