RFR: 8307840: SequencedMap view method specification and implementation adjustments

Stuart Marks smarks at openjdk.org
Tue Jun 6 17:05:38 UTC 2023


On Tue, 6 Jun 2023 04:55:10 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> Adjust the specification of the `SequencedMap` sequenced-view methods, and adjust implementations to match.
>
> src/java.base/share/classes/java/util/SequencedMap.java line 268:
> 
>> 266:      * Its {@link SequencedSet#reversed reversed} method returns the {@link
>> 267:      * #sequencedKeySet sequencedKeySet} view of the {@link #reversed reversed} view of
>> 268:      * this map. Each of its other methods calls the corresponding method of the {@link
> 
> Hello Stuart, should this (and other similar places in this PR) instead be:
> 
> Each of its other methods call
> 
> call instead of calls?

"Each" is usually considered singular so "Each ... calls" is proper. It looks weird though since the plural "methods" is right next to "calls."

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14267#discussion_r1220010473


More information about the core-libs-dev mailing list