RFR: 8306431: File.listRoots method description should be re-examined [v8]

Alan Bateman alanb at openjdk.org
Wed Jun 7 12:11:57 UTC 2023


On Wed, 7 Jun 2023 08:16:19 GMT, Nagata-Haruhito <duke at openjdk.org> wrote:

>> I fixed File.listRoots description.
>> * remove "the insertion or ejection of removable media"
>> * change "available" to "existing"
>> 
>> Please review this change.
>
> Nagata-Haruhito has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Refer review comment

src/java.base/share/classes/java/io/File.java line 1822:

> 1820:      * that the canonical pathname of any file physically present on the local
> 1821:      * machine will begin with one of the roots returned by this method.
> 1822:      * There is no guarantee that the root directory can be accessed.

The current patch looks okay, just need to change "the root directory" to "a root directory", here and also in FileSystem::getRootDirectories.

I see a CSR has been created. If you don't mind, I will edit it to make it clearer what this is about.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13526#discussion_r1221472561


More information about the core-libs-dev mailing list