RFR: 8306431: File.listRoots method description should be re-examined [v8]
Alan Bateman
alanb at openjdk.org
Wed Jun 7 17:34:22 UTC 2023
On Wed, 7 Jun 2023 12:09:33 GMT, Alan Bateman <alanb at openjdk.org> wrote:
>> Nagata-Haruhito has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Refer review comment
>
> src/java.base/share/classes/java/io/File.java line 1822:
>
>> 1820: * that the canonical pathname of any file physically present on the local
>> 1821: * machine will begin with one of the roots returned by this method.
>> 1822: * There is no guarantee that the root directory can be accessed.
>
> The current patch looks okay, just need to change "the root directory" to "a root directory", here and also in FileSystem::getRootDirectories.
>
> I see a CSR has been created. If you don't mind, I will edit it to make it clearer what this is about.
The CSR is updated so it's focused on the two parts of the updated docs. So I think you can finalize.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13526#discussion_r1221944247
More information about the core-libs-dev
mailing list