RFR: 8308645: Javadoc of FFM API needs to be refreshed [v4]

Maurizio Cimadamore mcimadamore at openjdk.org
Fri Jun 9 13:44:58 UTC 2023


On Thu, 8 Jun 2023 20:21:48 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

>> test/jdk/java/foreign/TestLayoutPaths.java line 125:
>> 
>>> 123:     }
>>> 124: 
>>> 125:     public void testByteOffsetHandleRange() {
>> 
>> Missing `@Test`?
>
> FWIW, it looks like this needs `@Test(expectedExceptions = IllegalArgumentException.class)` since range elements are not allowed for `byteOffsetHandle`

Note sure - javadoc says:

* @throws IllegalArgumentException if the layout path is not <a href="#well-formedness">well-formed</a> for this layout.
     * @throws IllegalArgumentException if the layout path contains one or more <a href=#deref-path-elements>dereference path elements</a>.


Which seems correct. The handle version can accept indices, so that's ok?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14098#discussion_r1224327629


More information about the core-libs-dev mailing list