RFR: 8308645: Javadoc of FFM API needs to be refreshed [v4]

Maurizio Cimadamore mcimadamore at openjdk.org
Fri Jun 9 13:44:59 UTC 2023


On Fri, 9 Jun 2023 13:40:47 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> FWIW, it looks like this needs `@Test(expectedExceptions = IllegalArgumentException.class)` since range elements are not allowed for `byteOffsetHandle`
>
> Note sure - javadoc says:
> 
> * @throws IllegalArgumentException if the layout path is not <a href="#well-formedness">well-formed</a> for this layout.
>      * @throws IllegalArgumentException if the layout path contains one or more <a href=#deref-path-elements>dereference path elements</a>.
> 
> 
> Which seems correct. The handle version can accept indices, so that's ok?

Note that the javadoc has been rectified here (as part of the PR) as I think it has always been wrong in the past (probably cut and paste issue from the non-MH version?)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14098#discussion_r1224329494


More information about the core-libs-dev mailing list