RFR: JDK-8308047 java/util/concurrent/ScheduledThreadPoolExecutor/BasicCancelTest.java timed out and also had jcmd pipe errors [v2]

Alan Bateman alanb at openjdk.org
Fri Jun 9 16:55:46 UTC 2023


On Fri, 9 Jun 2023 10:07:31 GMT, Viktor Klang <duke at openjdk.org> wrote:

>> The test used a too-small heap for generic testing, and coupled with looking at `freeMemory()` it led to a less-than-ideal determinism of execution of the test.
>
> Viktor Klang has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Decresing the number of iterations proportional to the increase in the max memory size

This looks okay to me and I assume it tested on with all GCs/configurations. If it comes back then maybe an alternative way to test this would be a timed loop of submit+task. If the cancel policy isn't working then it would throw OOME very quickly with a 64Mb heap.

-------------

Marked as reviewed by alanb (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/14389#pullrequestreview-1472651211


More information about the core-libs-dev mailing list