RFR: JDK-8308047 java/util/concurrent/ScheduledThreadPoolExecutor/BasicCancelTest.java timed out and also had jcmd pipe errors [v2]

Viktor Klang duke at openjdk.org
Sun Jun 11 11:40:55 UTC 2023


On Fri, 9 Jun 2023 16:53:05 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Viktor Klang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Decresing the number of iterations proportional to the increase in the max memory size
>
> This looks okay to me and I assume it tested on with all GCs/configurations. If it comes back then maybe an alternative way to test this would be a timed loop of submit+task. If the cancel policy isn't working then it would throw OOME very quickly with a 64Mb heap.

@AlanBateman Yes, i've run it extensively. I decided against running it in a timed loop because that would technically make it succeed if the application thread didn't get enough CPU-time. (And makes it difficult to know how it behaves on very slow machines)

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14389#issuecomment-1586129041


More information about the core-libs-dev mailing list