RFR: 8308645: Javadoc of FFM API needs to be refreshed [v4]
Jorn Vernee
jvernee at openjdk.org
Fri Jun 9 18:25:29 UTC 2023
On Fri, 9 Jun 2023 13:42:17 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:
>> Note sure - javadoc says:
>>
>> * @throws IllegalArgumentException if the layout path is not <a href="#well-formedness">well-formed</a> for this layout.
>> * @throws IllegalArgumentException if the layout path contains one or more <a href=#deref-path-elements>dereference path elements</a>.
>>
>>
>> Which seems correct. The handle version can accept indices, so that's ok?
>
> Note that the javadoc has been rectified here (as part of the PR) as I think it has always been wrong in the past (probably cut and paste issue from the non-MH version?)
But, the implementation of `byteOffsetHandle` rejects range elements: https://github.com/openjdk/jdk/pull/14098/files/265e0d5b082ad54d1cadea1d4a8bd844e72e3926#diff-90ecdacbee63a90f6e695a8bb4c1ad69b591602501613a774561c4032f01fb95R352
So this test fails (at least it does here...)
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14098#discussion_r1224616797
More information about the core-libs-dev
mailing list