RFR: 8303920: Avoid calling out to python in DataDescriptorSignatureMissing test

Jaikiran Pai jpai at openjdk.org
Fri Mar 10 07:50:05 UTC 2023


On Thu, 9 Mar 2023 19:53:44 GMT, Eirik Bjorsnos <duke at openjdk.org> wrote:

> Please review this PR which brings  the DataDescriptorSignatureMissing test back to life.
> 
> This test currently calls out to Python to create a test vector ZIP with a Data Descriptor without the recommended but optional signature. The Python dependency has turned out to be very brittle, so the test is currently marked with `@ignore` 
> 
> The PR replaces Python callouts with directly creating the test vector ZIP in the test itself. We can then remove the `@ignore`tag and run this useful test automatically.

test/jdk/java/util/zip/DataDescriptorSignatureMissing.java line 29:

> 27:  * @summary Check ability to read zip files created by python zipfile
> 28:  * implementation, which fails to write optional (but recommended) data
> 29:  * descriptor signatures.

Hello Eirik, I think the summary should no longer have references to python. Since this test was introduced for https://bugs.openjdk.org/browse/JDK-8056934, perhaps we can just change the `@summary` of this test definition to say:
>
>@summary Verify the ability to read zip files whose local header data descriptor is missing the optional signature

-------------

PR: https://git.openjdk.org/jdk/pull/12959


More information about the core-libs-dev mailing list