RFR: 8303920: Avoid calling out to python in DataDescriptorSignatureMissing test [v2]
Eirik Bjorsnos
duke at openjdk.org
Fri Mar 10 08:01:53 UTC 2023
On Fri, 10 Mar 2023 07:47:05 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:
>> Eirik Bjorsnos has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Remove reference to python in the @summary of DataDescriptorSignatureMissing
>
> test/jdk/java/util/zip/DataDescriptorSignatureMissing.java line 29:
>
>> 27: * @summary Check ability to read zip files created by python zipfile
>> 28: * implementation, which fails to write optional (but recommended) data
>> 29: * descriptor signatures.
>
> Hello Eirik, I think the summary should no longer have references to python. Since this test was introduced for https://bugs.openjdk.org/browse/JDK-8056934, perhaps we can just change the `@summary` of this test definition to say:
>>
>>@summary Verify the ability to read zip files whose local header data descriptor is missing the optional signature
Thanks, I updated the summary according to your suggestion. I left it there to keep the history/context of the test, but I guess that's a bit detailed and is already captured in the bug.
-------------
PR: https://git.openjdk.org/jdk/pull/12959
More information about the core-libs-dev
mailing list