RFR: 8303920: Avoid calling out to python in DataDescriptorSignatureMissing test [v2]
Eirik Bjorsnos
duke at openjdk.org
Fri Mar 10 08:01:51 UTC 2023
> Please review this PR which brings the DataDescriptorSignatureMissing test back to life.
>
> This test currently calls out to Python to create a test vector ZIP with a Data Descriptor without the recommended but optional signature. The Python dependency has turned out to be very brittle, so the test is currently marked with `@ignore`
>
> The PR replaces Python callouts with directly creating the test vector ZIP in the test itself. We can then remove the `@ignore`tag and run this useful test automatically.
Eirik Bjorsnos has updated the pull request incrementally with one additional commit since the last revision:
Remove reference to python in the @summary of DataDescriptorSignatureMissing
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/12959/files
- new: https://git.openjdk.org/jdk/pull/12959/files/a145693b..064aa3b9
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=12959&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=12959&range=00-01
Stats: 3 lines in 1 file changed: 0 ins; 1 del; 2 mod
Patch: https://git.openjdk.org/jdk/pull/12959.diff
Fetch: git fetch https://git.openjdk.org/jdk pull/12959/head:pull/12959
PR: https://git.openjdk.org/jdk/pull/12959
More information about the core-libs-dev
mailing list