RFR: 8294974: jdk.jshell jdk.jshell.execution.LocalExecutionControl uses ASM to instrument classes [v3]

[Jan Lahoda]

On Fri, 10 Mar 2023 12:35:31 GMT, Adam Sotona <asotona at openjdk.org> wrote:

>> 8294974: jdk.jshell jdk.jshell.execution.LocalExecutionControl uses ASM to instrument classes
>> This patch converts it to use Classfile API.
>> 
>> Please review.
>> Thanks,
>> Adam
>
> Adam Sotona has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 194 commits:
> 
>  - Merge branch 'master' into JDK-8294974-jshell
>  - Merge branch 'master' into JDK-8294974-jshell
>  - Merge branch 'master' into JDK-8294974-jshell
>  - Merge branch 'JDK-8294982' into JDK-8294974
>  - removed obsolete javadoc from implementation classes
>  - minor fix in CodeBuilder and added test cases to LDCTest
>  - EntryMap::nextPowerOfTwo delegates to Long:numberOfLeadingZeros
>  - fixed CodeBuilder:constantInstruction for -0.0d and -0.0f values and added test
>  - Merge branch 'master' into JDK-8294982
>  - fixed new lines at end of file
>  - ... and 184 more: https://git.openjdk.org/jdk/compare/b1d89f30...070be0a8

Looks good to me, with a nit in java.base's module-info.

src/java.base/share/classes/module-info.java line 384:

> 382:     exports sun.util.resources to
> 383:         jdk.localedata;
> 384: 

Nit: I'd suggest to preserve the empty line (since there's no other change near).

-------------

Marked as reviewed by jlahoda (Reviewer).

PR: https://git.openjdk.org/jdk/pull/11413