RFR: 8294974: jdk.jshell jdk.jshell.execution.LocalExecutionControl uses ASM to instrument classes [v2]
Adam Sotona
asotona at openjdk.org
Fri Mar 10 13:09:12 UTC 2023
On Fri, 10 Mar 2023 12:58:25 GMT, Jan Lahoda <jlahoda at openjdk.org> wrote:
>> Adam Sotona has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 193 commits:
>>
>> - Merge branch 'master' into JDK-8294974-jshell
>> - Merge branch 'master' into JDK-8294974-jshell
>> - Merge branch 'JDK-8294982' into JDK-8294974
>> - removed obsolete javadoc from implementation classes
>> - minor fix in CodeBuilder and added test cases to LDCTest
>> - EntryMap::nextPowerOfTwo delegates to Long:numberOfLeadingZeros
>> - fixed CodeBuilder:constantInstruction for -0.0d and -0.0f values and added test
>> - Merge branch 'master' into JDK-8294982
>> - fixed new lines at end of file
>> - package jdk.internal.classfile.jdktypes moved to jdk.internal.classfile.java.lang.constant
>> - ... and 183 more: https://git.openjdk.org/jdk/compare/e26cc526...f9fb8998
>
> src/java.base/share/classes/module-info.java line 384:
>
>> 382: jdk.jshell;
>> 383: exports jdk.internal.classfile.instruction to
>> 384: jdk.jshell;
>
> Nit: I'd suggest to preserve the empty line (since there's no other change near).
fixed, thanks.
-------------
PR: https://git.openjdk.org/jdk/pull/11413
More information about the core-libs-dev
mailing list