RFR: 8303910: jdk/classfile/CorpusTest.java failed 1 of 6754 tests [v2]
Adam Sotona
asotona at openjdk.org
Mon Mar 13 21:02:54 UTC 2023
On Mon, 13 Mar 2023 19:04:45 GMT, liach <duke at openjdk.org> wrote:
>> Adam Sotona has updated the pull request incrementally with one additional commit since the last revision:
>>
>> throwing IllegalArgumentException instead of IllegalStateException
>
> src/java.base/share/classes/jdk/internal/classfile/TypeKind.java line 112:
>
>> 110: case 10 -> TypeKind.IntType;
>> 111: case 11 -> TypeKind.LongType;
>> 112: default -> throw new IllegalStateException("Bad new array code: " + newarraycode);
>
> Should throw `IllegalArgumentException` to be more informative
Right, I've changed it on both places in `TypeKind`, thanks.
-------------
PR: https://git.openjdk.org/jdk/pull/13004
More information about the core-libs-dev
mailing list