RFR: 8303910: jdk/classfile/CorpusTest.java failed 1 of 6754 tests [v2]

Adam Sotona asotona at openjdk.org
Mon Mar 13 21:02:51 UTC 2023


> jdk/classfile/CorpusTest.java rarely fails in 1 of 6754 parametrised parallel junit tests
> 
> The root cause seems to be thread-unsafe lazy initialisation of `TypeKind.newarraycodeToTypeTag` in `TypeKind::fromNewArrayCode`. Provided patch replaces that lazy-initialized helper array with switch expression.
> 
> Please review.
> 
> Thanks,
> Adam

Adam Sotona has updated the pull request incrementally with one additional commit since the last revision:

  throwing IllegalArgumentException instead of IllegalStateException

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/13004/files
  - new: https://git.openjdk.org/jdk/pull/13004/files/f6291c1d..b8631e12

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=13004&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=13004&range=00-01

  Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/13004.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/13004/head:pull/13004

PR: https://git.openjdk.org/jdk/pull/13004


More information about the core-libs-dev mailing list