RFR: 8303910: jdk/classfile/CorpusTest.java failed 1 of 6754 tests [v2]

liach duke at openjdk.org
Mon Mar 13 23:04:48 UTC 2023


On Mon, 13 Mar 2023 21:02:51 GMT, Adam Sotona <asotona at openjdk.org> wrote:

>> jdk/classfile/CorpusTest.java rarely fails in 1 of 6754 parametrised parallel junit tests
>> 
>> The root cause seems to be thread-unsafe lazy initialisation of `TypeKind.newarraycodeToTypeTag` in `TypeKind::fromNewArrayCode`. Provided patch replaces that lazy-initialized helper array with switch expression.
>> 
>> Please review.
>> 
>> Thanks,
>> Adam
>
> Adam Sotona has updated the pull request incrementally with one additional commit since the last revision:
> 
>   throwing IllegalArgumentException instead of IllegalStateException

Marked as reviewed by liach at github.com (no known OpenJDK username).

-------------

PR: https://git.openjdk.org/jdk/pull/13004


More information about the core-libs-dev mailing list