RFR: 8294962: Convert java.base/jdk.internal.module package to use the Classfile API to modify and write module-info.class [v6]
Mandy Chung
mchung at openjdk.org
Tue Mar 14 17:14:24 UTC 2023
On Tue, 14 Mar 2023 15:47:33 GMT, Adam Sotona <asotona at openjdk.org> wrote:
>> 8294962: java.base jdk.internal.module package uses ASM to modify and write module-info.class.
>> This patch converts it to use Classfile API.
>>
>> Please review.
>> Thanks,
>> Adam
>
> Adam Sotona has updated the pull request incrementally with one additional commit since the last revision:
>
> fixed formatting
src/java.base/share/classes/jdk/internal/module/ModuleInfoWriter.java line 150:
> 148: // packages
> 149: var packages = md.packages().stream().sorted().map(PackageDesc::of).toList();
> 150: if (!packages.isEmpty()) {
This check should be `if (md.packages().size() > exportedOrOpen)` or a bug in ModuleInfoWriter?
-------------
PR: https://git.openjdk.org/jdk/pull/11368
More information about the core-libs-dev
mailing list