RFR: 8294962: Convert java.base/jdk.internal.module package to use the Classfile API to modify and write module-info.class [v6]

[Alan Bateman]

On Tue, 14 Mar 2023 17:10:07 GMT, Mandy Chung <mchung at openjdk.org> wrote:

>> Adam Sotona has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fixed formatting
>
> src/java.base/share/classes/jdk/internal/module/ModuleInfoWriter.java line 150:
> 
>> 148:                 // packages
>> 149:                 var packages = md.packages().stream().sorted().map(PackageDesc::of).toList();
>> 150:                 if (!packages.isEmpty()) {
> 
> This check should be `if (md.packages().size() > exportedOrOpen)` or a bug in ModuleInfoWriter?

An oddity in ModuleInfoWriter that I think dates from when a prototype version of this attribute contains the set of concealed packages. There's no need for ModuleInfoWriter to emit the ModulePackages attribute, Adam has chosen to have it emit it. It has implications for one test for ModuleDescriptor.read, and he's changed that.

-------------

PR: https://git.openjdk.org/jdk/pull/11368