RFR: 8303930: Fix ConstantUtils.skipOverFieldSignature void case return value [v3]

Chen Liang liach at openjdk.org
Tue Mar 21 20:21:23 UTC 2023


> This typo doesn't allow creation of malformed ClassDesc or MethodTypeDesc, but it produces an erroneous exception on certain inputs. Running `java.lang.constant.MethodTypeDesc.ofDescriptor("(IIIII[[[V)I")` in Jshell 19.0.2 throws StringIndexOutOfBoundsException, and throws IllegalArgumentException in the Jshell for this patch.

Chen Liang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:

 - Merge branch 'master' of https://git.openjdk.java.net/jdk into 8303930
 - Add test for skipOverFieldSignature bug
 - Merge branch 'master' of https://git.openjdk.java.net/jdk into 8303930
 - Copyright year
 - 8303930: Fix ConstantUtils.skipOverFieldSignature void case return value

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/12964/files
  - new: https://git.openjdk.org/jdk/pull/12964/files/d7b38bcf..f53269ca

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=12964&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=12964&range=01-02

  Stats: 82754 lines in 1011 files changed: 50645 ins; 22368 del; 9741 mod
  Patch: https://git.openjdk.org/jdk/pull/12964.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/12964/head:pull/12964

PR: https://git.openjdk.org/jdk/pull/12964


More information about the core-libs-dev mailing list