RFR: 8303930: Fix ConstantUtils.skipOverFieldSignature void case return value [v3]

Chen Liang liach at openjdk.org
Thu Mar 23 02:36:43 UTC 2023


On Tue, 21 Mar 2023 20:21:23 GMT, Chen Liang <liach at openjdk.org> wrote:

>> This typo doesn't allow creation of malformed ClassDesc or MethodTypeDesc, but it produces an erroneous exception on certain inputs. Running `java.lang.constant.MethodTypeDesc.ofDescriptor("(IIIII[[[V)I")` in Jshell 19.0.2 throws StringIndexOutOfBoundsException, and throws IllegalArgumentException in the Jshell for this patch.
>
> Chen Liang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
> 
>  - Merge branch 'master' of https://git.openjdk.java.net/jdk into 8303930
>  - Add test for skipOverFieldSignature bug
>  - Merge branch 'master' of https://git.openjdk.java.net/jdk into 8303930
>  - Copyright year
>  - 8303930: Fix ConstantUtils.skipOverFieldSignature void case return value

Could any engineer please review this patch fixing `ConstantUtils.skipOverFieldSignature` throwing `StringIndexOutOfBoundsException` on certain crafted inputs?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/12964#issuecomment-1480500845


More information about the core-libs-dev mailing list