RFR: 8304913: Use OperatingSystem, Architecture, and Version in jlink [v3]

[Alan Bateman]

On Fri, 5 May 2023 13:59:37 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> Refactor the Platform class of jlink to use jdk.internal.util OperatingSystem and Architecture instead of os.name and os.arch. 
>> They are direct replacements for the Platform enums except for UNKNOWN; its use is refactored to report errors via exceptions.
>> 
>> Neither os.name nor os.arch should be assumed to be changeable; 
>> one test case is removed because it assumes os.name can be changed on the command line.
>
> Roger Riggs has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Source code cleanup suggested by reviewers

Aside from one confusing comment, this change looks okay.

src/jdk.jlink/share/classes/jdk/tools/jlink/internal/Platform.java line 53:

> 51: 
> 52:         archName = platformString.substring(index + 1);
> 53:         // Unalias Jmod architecture "amd64" to "x86_64"

"Jmod architecture" is confusing here, it's the architecture component of the ModuleTarget attribute.

-------------

Marked as reviewed by alanb (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/13585#pullrequestreview-1415778171
PR Review Comment: https://git.openjdk.org/jdk/pull/13585#discussion_r1186699156