RFR: 8304913: Use OperatingSystem, Architecture, and Version in jlink [v3]
Mandy Chung
mchung at openjdk.org
Sun May 7 08:27:18 UTC 2023
On Fri, 5 May 2023 13:59:37 GMT, Roger Riggs <rriggs at openjdk.org> wrote:
>> Refactor the Platform class of jlink to use jdk.internal.util OperatingSystem and Architecture instead of os.name and os.arch.
>> They are direct replacements for the Platform enums except for UNKNOWN; its use is refactored to report errors via exceptions.
>>
>> Neither os.name nor os.arch should be assumed to be changeable;
>> one test case is removed because it assumes os.name can be changed on the command line.
>
> Roger Riggs has updated the pull request incrementally with one additional commit since the last revision:
>
> Source code cleanup suggested by reviewers
I suggest to remove `Platform::is64Bit` and simply call `Architecture::is64bit`. Otherwise, looks fine.
-------------
Marked as reviewed by mchung (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/13585#pullrequestreview-1415865569
More information about the core-libs-dev
mailing list