RFR: 8304914: Use OperatingSystem, Architecture, and Version in jpackage [v2]

Roger Riggs rriggs at openjdk.org
Mon May 15 20:21:52 UTC 2023


On Fri, 5 May 2023 14:12:21 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> Refactor the Platform class in jdk.jpackage to use the internal OperatingSystem, Architecture, and Version classes.
>> The OperatingSystem.isXXX() and Architecture.isYYY() methods replace comparisons in the Platform class.
>> The checks of the os.version are replaced but may not be needed if OpenJDK no longer supports them.
>> 
>> It is recommended to remove os version checks that apply only to Mac versions before 10.15.
>> Mac OS X 10.15 is the oldest version supported.
>
> Roger Riggs has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Minor source code style cleanup

One difference between the original `Platform` enum and the `OperatingSystem` enum is the handling of AIX.
In the original AIX is mapped to Linux.  The `OperatingSystem` enum considers it a separate value. 
When dispatching on the OperatingSystem, Linux and AIX should take the same actions.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/13586#issuecomment-1548518677


More information about the core-libs-dev mailing list