RFR: 8304914: Use OperatingSystem, Architecture, and Version in jpackage [v3]

Roger Riggs rriggs at openjdk.org
Mon May 15 22:51:52 UTC 2023


> Refactor the Platform class in jdk.jpackage to use the internal OperatingSystem, Architecture, and Version classes.
> The OperatingSystem.isXXX() and Architecture.isYYY() methods replace comparisons in the Platform class.
> The checks of the os.version are replaced but may not be needed if OpenJDK no longer supports them.
> 
> It is recommended to remove os version checks that apply only to Mac versions before 10.15.
> Mac OS X 10.15 is the oldest version supported.

Roger Riggs has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 34 commits:

 - Merge branch 'master' into 8304914-os-jpackage
 - The OperatingSystem enum treats AIX separately from Linux. The original Platform used the same enum for both.
   Whereever OperatingSystem.isLinux is used in jpackage it should include isAix as well.
 - Minor source code style cleanup
 - Merge branch 'master' into 8304914-os-jpackage
 - Merge branch '8306678-os-version' into 8304914-os-jpackage
 - Merge branch '8304915-arch-enum' into 8306678-os-version
 - Correct comment on isPPC64() and refer to isLittleEndian() instead of mentioning PPC64LE
 - Simplify initialization in ClassLoaderHelper and fix VersionTest.
 - Revert changes to MacOsX sun.nio.fs.BsdFileStore; the version check is being removed in another PR.
 - Review comment updates
 - ... and 24 more: https://git.openjdk.org/jdk/compare/7b0b9b57...64ab7126

-------------

Changes: https://git.openjdk.org/jdk/pull/13586/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=13586&range=02
  Stats: 239 lines in 23 files changed: 44 ins; 132 del; 63 mod
  Patch: https://git.openjdk.org/jdk/pull/13586.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/13586/head:pull/13586

PR: https://git.openjdk.org/jdk/pull/13586


More information about the core-libs-dev mailing list