RFR: 8307990: jspawnhelper must close its writing side of a pipe before reading from it [v2]

Volker Simonis simonis at openjdk.org
Wed May 17 16:15:16 UTC 2023


On Wed, 17 May 2023 14:10:59 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Volker Simonis has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Added test case
>
> src/java.base/unix/native/libjava/ProcessImpl_md.c line 490:
> 
>> 488:     pid_t resultPid;
>> 489:     int i, offset, rval, bufsize, magic;
>> 490:     char *buf, buf1[24];
> 
> Since you are here could you please increase buffer size to something safe? Max len of INT_MIN is 11 bytes, so lets have at least 3*11 + 3 bytes.

OK, so let it be (until we get 64-bit integers and file descriptors :)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13956#discussion_r1196768397


More information about the core-libs-dev mailing list