RFR: 8307990: jspawnhelper must close its writing side of a pipe before reading from it [v2]

[Thomas Stuefe]

On Wed, 17 May 2023 16:12:15 GMT, Volker Simonis <simonis at openjdk.org> wrote:

>> src/java.base/unix/native/libjava/ProcessImpl_md.c line 490:
>> 
>>> 488:     pid_t resultPid;
>>> 489:     int i, offset, rval, bufsize, magic;
>>> 490:     char *buf, buf1[24];
>> 
>> Since you are here could you please increase buffer size to something safe? Max len of INT_MIN is 11 bytes, so lets have at least 3*11 + 3 bytes.
>
> OK, so let it be (until we get 64-bit integers and file descriptors :)

Ok, if you let it be, I fix it in a separate RFE. Cleaner that way anyway. 

I filed https://bugs.openjdk.org/browse/JDK-8308350 and https://github.com/openjdk/jdk/pull/14045. 

Should I happen to push before you, this should be easily adaptable for you.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13956#discussion_r1197488813