RFR: 8187655: jdk.lambda.vm.InterfaceAccessFlagsTest.testPrivateMethodCall needs update after nestmates support [v3]
Adam Sotona
asotona at openjdk.org
Wed Nov 8 17:18:58 UTC 2023
On Wed, 8 Nov 2023 17:10:11 GMT, Mandy Chung <mchung at openjdk.org> wrote:
>> `jdk.lambda.vm.InterfaceAccessFlagsTest` uses `ClassToInterfaceConverter` to mechanically convert a classfile for a Class into an in-memory class representation of an equivalent Interface. `testPrivateMethodCall` tests to invoke a private method. Before nestmates, invoking a private class method and a private interface method both use `Invokespecial`. With the nestmate changes, the class uses `invokevirtual` but the interface must use `invokeinterface` but this conversion is not handled by the existing `ClassToInterfaceConverter`.
>>
>> This fix converts `ClassToInterfaceConverter` to use the Class-File API to properly convert a classfile from a class to an interface including method invocation from `invokevirtual` to `invokeinterface`. The old custom bytecode manipulation code can be dropped.
>
> Mandy Chung has updated the pull request incrementally with one additional commit since the last revision:
>
> fix whitespace and minor changes per review feedback
Looks good.
-------------
Marked as reviewed by asotona (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/16526#pullrequestreview-1720882604
More information about the core-libs-dev
mailing list