Integrated: 8187655: jdk.lambda.vm.InterfaceAccessFlagsTest.testPrivateMethodCall needs update after nestmates support

Mandy Chung mchung at openjdk.org
Wed Nov 8 20:02:09 UTC 2023


On Mon, 6 Nov 2023 19:26:26 GMT, Mandy Chung <mchung at openjdk.org> wrote:

> `jdk.lambda.vm.InterfaceAccessFlagsTest` uses `ClassToInterfaceConverter` to mechanically convert a classfile for a Class into an in-memory class representation of an equivalent Interface.  `testPrivateMethodCall`  tests to invoke a private method. Before nestmates, invoking a private class method and a private interface method both use `Invokespecial`.   With the nestmate changes, the class uses `invokevirtual` but the interface must use `invokeinterface` but this conversion is not handled by the existing `ClassToInterfaceConverter`.
> 
> This fix converts `ClassToInterfaceConverter` to use the Class-File API to properly convert a classfile from a class to an interface including method invocation from `invokevirtual` to `invokeinterface`.  The old custom bytecode manipulation code can be dropped.

This pull request has now been integrated.

Changeset: c137b17e
Author:    Mandy Chung <mchung at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/c137b17e82f90df07f4d8a5341b836a636a63ce1
Stats:     593 lines in 5 files changed: 6 ins; 559 del; 28 mod

8187655: jdk.lambda.vm.InterfaceAccessFlagsTest.testPrivateMethodCall needs update after nestmates support

Reviewed-by: liach, asotona

-------------

PR: https://git.openjdk.org/jdk/pull/16526


More information about the core-libs-dev mailing list