RFR: JDK-8319662 ForkJoinPool trims worker threads too slowly [v3]
Viktor Klang
vklang at openjdk.org
Tue Nov 21 21:30:08 UTC 2023
On Tue, 21 Nov 2023 17:12:39 GMT, Doug Lea <dl at openjdk.org> wrote:
>> This update cascades timeouts to trim subsequent workers after the first keepAlive inactive period.
>
> Doug Lea has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>
> - Merge branch 'openjdk:master' into JDK-8319662
> - tweak cascades; reinstate an @Contended; resolve JDK-8319498
> - Support cascading idle timeouts
src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java line 3116:
> 3114: } catch (Exception ex) {
> 3115: throw new RuntimeException(ex);
> 3116: }
Suggestion:
try {
return task.join();
} catch (RuntimeException | Error unchecked) {
throw unchecked;
} catch (Exception checked) {
throw new RuntimeException(checked);
}
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16725#discussion_r1401218927
More information about the core-libs-dev
mailing list